On 6/22/26 12:59 AM, Eliot Courtney wrote: > On Mon Jun 22, 2026 at 4:10 PM JST, Alexandre Courbot wrote: >> The next patch aims at replacing the cumbersome `BootUnloadGuard` with a >> more local and less intrusive mechanism to run the GSP unload sequence >> upon GSP boot failure. Doing so requires running the boot code in a >> local closure, which changes its indentation and would make other >> changes difficult to track in the diff. Thus, this preparatory patch >> moves said boot code into a local closure that is run upon construction, >> so the next patch does not need to re-indent code that changes. >> >> This is a mechanical preparatory patch to make the next patch easier to >> read. No functional change intended. >> >> Signed-off-by: Alexandre Courbot <[email protected]> >> --- > > See my response at [1]. > > [1]: https://lore.kernel.org/all/[email protected]/
I'm relieved to see us going with RAII scope guards instead of a pile of closures. But now I'm tempted to wait for a v3 that does that, before reviewing, on the assumption that the rest of the series changes quite a bit as a result. thanks, -- John Hubbard
