Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [Low] Use of `additionalProperties: false` breaks inheritance of common panel properties. - [Low] Missing space before brace in the device tree example. --
commit a15a27453070f4b1a8c8e896b7b599f3e42a0e6c Author: Pengyu Luo <[email protected]> dt-bindings: display: panel: Add Novatek NT36536 This commit adds a new device tree binding for the Novatek NT36536 DSI display panel used in the LENOVO Legion Y700 Gen4. > diff --git > a/Documentation/devicetree/bindings/display/panel/novatek,nt36536.yaml > b/Documentation/devicetree/bindings/display/panel/novatek,nt36536.yaml > new file mode 100644 > index 0000000000000..06f4d1e0ee4a0 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36536.yaml > @@ -0,0 +1,90 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/novatek,nt36536.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Novatek NT36536 based DSI display Panels [ ... ] > +allOf: > + - $ref: panel-common-dual.yaml# > + > +properties: [ ... ] > +required: > + - compatible > + - reg > + - vddio-supply > + - reset-gpios > + - ports > + > +additionalProperties: false [Severity: Low] Does using additionalProperties: false here break the inheritance of properties from panel-common-dual.yaml#? The schema validator might reject standard panel properties since additionalProperties: false only considers properties explicitly defined in the local file's properties block. Should this be unevaluatedProperties: false instead? > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + > + dsi { [ ... ] > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + panel_in_0: endpoint { > + remote-endpoint = <&dsi0_out>; > + }; > + }; > + > + port@1{ [Severity: Low] This isn't a bug, but there is a missing space before the brace here. > + reg = <1>; > + panel_in_1: endpoint { > + remote-endpoint = <&dsi1_out>; > + }; > + }; -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
