Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Incomplete conversion to vertical import style. --
commit 515257218c25a2eecc8bad4b4c78d96ae90b1e95 Author: Guru Das Srinagesh <[email protected]> cpufreq: rcpufreq_dt: use vertical import style This commit updates the device imports in rcpufreq_dt.rs to use a vertical layout for better readability. > diff --git a/drivers/cpufreq/rcpufreq_dt.rs b/drivers/cpufreq/rcpufreq_dt.rs > index 10106fa13095e..6f83cf8955a68 100644 > --- a/drivers/cpufreq/rcpufreq_dt.rs > +++ b/drivers/cpufreq/rcpufreq_dt.rs > @@ -6,7 +6,10 @@ > clk::Clk, > cpu, cpufreq, > cpumask::CpumaskVar, > - device::{Core, Device}, > + device::{ > + Core, > + Device, // > + }, > error::code::*, > macros::vtable, > module_platform_driver, of, opp, platform, [Severity: Low] This isn't a bug, but since this commit touches the imports to convert them to a vertical layout, should the rest of this outer block also be updated? Items like cpu, cpufreq, and module_platform_driver, of, opp, platform, are still grouped horizontally. The Rust subsystem guidelines prefer a fully vertical style when an import block is modified. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=3
