Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Incomplete conversion to the vertical import style. --
commit 6c2e9db0f7ba63fbe028e5d4f157502143caf612 Author: Guru Das Srinagesh <[email protected]> Subject: block: rnull: use vertical import style This commit converts the use imports in the rnull block driver to a vertical layout to improve readability and maintainability. > diff --git a/drivers/block/rnull/configfs.rs b/drivers/block/rnull/configfs.rs > index 7c2eb5c0b7228..07ce21a440813 100644 > --- a/drivers/block/rnull/configfs.rs > +++ b/drivers/block/rnull/configfs.rs > @@ -2,14 +2,26 @@ > > use super::{NullBlkDevice, THIS_MODULE}; [Severity: Low] This isn't a bug, but should this import also be converted to the vertical layout since it contains multiple items in braces? [ ... ] > new_mutex, > page::PAGE_SIZE, > prelude::*, > - str::{kstrtobool_bytes, CString}, > + str::{ > + kstrtobool_bytes, > + CString, // > + }, > sync::Mutex, > }; [Severity: Low] This isn't a bug, but does this final item of the outer block also need a trailing // to ensure rustfmt preserves the vertical formatting? > diff --git a/drivers/block/rnull/rnull.rs b/drivers/block/rnull/rnull.rs > index 0ca8715febe83..d58d2c4c5f635 100644 > --- a/drivers/block/rnull/rnull.rs > +++ b/drivers/block/rnull/rnull.rs [ ... ] > prelude::*, > - sync::{aref::ARef, Arc}, > + sync::{ > + aref::ARef, > + Arc, // > + }, > }; [Severity: Low] Similar to the configfs.rs file, does the sync block need a trailing // after its closing brace to keep the outer block vertically formatted? -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=4
