On 6/28/26 11:34 PM, Dan Carpenter wrote:
> The vmw_prime_import_sg_table() function is expected to return error
> pointers on error and not NULL. Otherwise it leads to a NULL dereference
> in the caller drm_gem_prime_import_dev().
>
> Change the NULL to ERR_PTR(-ENOMEM).
>
> Fixes: b32233acceff ("drm/vmwgfx: Fix prime import/export")
> Signed-off-by: Dan Carpenter <[email protected]>
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_gem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c
> b/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c
> index 39f8c46550c2..f25db04f8777 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_gem.c
> @@ -184,7 +184,7 @@ struct drm_gem_object *vmw_prime_import_sg_table(struct
> drm_device *dev,
> {
> int ret;
> struct vmw_private *dev_priv = vmw_priv(dev);
> - struct drm_gem_object *gem = NULL;
> + struct drm_gem_object *gem = ERR_PTR(-ENOMEM);
> struct vmw_bo *vbo;
> struct vmw_bo_params params = {
> .domain = (dev_priv->has_mob) ? VMW_BO_DOMAIN_SYS :
> VMW_BO_DOMAIN_VRAM,
LGTM!
Reviewed-by: Maaz Mombasawala <[email protected]>
--
Maaz Mombasawala <[email protected]>
