Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] Missing `power-domains` requirement for the newly added `fsl,imx8dxl-lcdif` and `fsl,imx8qxp-lcdif` compatible strings. --
--- Patch [1]: [PATCH 1/6] dt-bindings: lcdif: add compatible string for i.MX8QXP and i.MX8DXL --- commit 684d2e523ad2d6b2b8e88a7b19f827e3689efd97 Author: Frank Li <[email protected]> dt-bindings: lcdif: add compatible string for i.MX8QXP and i.MX8DXL i.MX8QXP and i.MX8DXL have lcdif, which back compatible with i.MX6SX. Add front compatible string "fsl,imx8dxl-lcdif" and "fsl,imx8qxp-lcdif", which fallback to "fsl,imx6sx-lcdif". > diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > index 2dd0411ec6516..121c1b220e698 100644 > --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml > @@ -28,9 +28,11 @@ properties: > - fsl,imx6sll-lcdif > - fsl,imx6ul-lcdif > - fsl,imx7d-lcdif > + - fsl,imx8dxl-lcdif > - fsl,imx8mm-lcdif > - fsl,imx8mn-lcdif > - fsl,imx8mq-lcdif > + - fsl,imx8qxp-lcdif > - const: fsl,imx6sx-lcdif [Severity: Medium] Will these newly added compatible strings also need to be included in the conditional block enforcing the power-domains property? Since these are SCU-based platforms that strictly require power domains (like IMX_SC_R_LCD_0), a device tree missing the power-domains property would silently pass validation but fail to power up at runtime. The existing schema enforces power domains via this allOf block, which does not match the new compatible strings: allOf: ... - if: properties: compatible: contains: enum: - fsl,imx6sl-lcdif - fsl,imx8mm-lcdif - fsl,imx8mn-lcdif - fsl,imx8mp-lcdif - fsl,imx93-lcdif then: required: - power-domains Because the new compatible strings are paired with the fsl,imx6sx-lcdif fallback as an array, they will also bypass the const: fsl,imx6sx-lcdif check found earlier in the file. Should fsl,imx8dxl-lcdif and fsl,imx8qxp-lcdif be added to the enum above so the requirement is properly enforced? -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
