Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [High] Overwriting `fsl,pins` in `pinctrl_hog` drops required system pin configurations, breaking GPIO expander interrupts. --
--- Patch [6]: [PATCH 6/6] arm64: dts: imx8dxl-evk: add lcdif overlay --- commit 85ecae823587c53fd00cdb23710f7c3efd6f900e Author: Frank Li <[email protected]> arm64: dts: imx8dxl-evk: add lcdif overlay This commit adds device tree overlay support for the waiken,101wx001 LCD panel on the imx8dxl-evk. It adds the overlay to the Makefile and introduces the new .dtso file that disables conflicting peripherals and reconfigures pinmuxes for LCDIF. > diff --git a/arch/arm64/boot/dts/freescale/imx8dxl-evk-lcdif.dtso > b/arch/arm64/boot/dts/freescale/imx8dxl-evk-lcdif.dtso > new file mode 100644 > index 0000000000000..c0e573fb5f915 > --- /dev/null > +++ b/arch/arm64/boot/dts/freescale/imx8dxl-evk-lcdif.dtso [ ... ] > +&iomuxc { > + pinctrl_hog: hoggrp { > + fsl,pins = < > + IMX8DXL_COMP_CTL_GPIO_1V8_3V3_GPIORHB_PAD 0x000514a0 > + >; > + }; > +}; [Severity: High] Does this unintentionally overwrite the base device tree's fsl,pins array for pinctrl_hog? Because device tree overlays replace array properties instead of merging them, redefining fsl,pins in pinctrl_hog to resolve a pin conflict will drop the other pins defined in the base tree's 4-pin array. Specifically, this deletes the mux configurations for IMX8DXL_COMP_CTL_GPIO_1V8_3V3_GPIORHK_PAD and IMX8DXL_SNVS_TAMPER_OUT1_LSIO_GPIO2_IO05_IN. Since LSIO_GPIO2_IO05 serves as the interrupt line for the pca6416_3 I2C GPIO expander, will dropping this configuration break all interrupts routed through the expander? [ ... ] -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=6
