Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] The commit message describes changes to the nouveau driver, but the patch modifies the amdxdna driver. --
--- Patch [3]: [PATCH 3/4] fixup! accel/amdxdna: use hmm_range_fault_unlocked_timeout() for range population --- commit b015bb79070e6f1c36006ca6ff7e7e113d7ecbd7 Author: Stanislav Kinsburskii <[email protected]> fixup! accel/amdxdna: use hmm_range_fault_unlocked_timeout() for range population This commit updates the hmm_range_fault_unlocked_timeout() usage to pass the full timeout value on each retry attempt. It also removes the open-coded absolute deadline and remaining-time calculation from the range population path. > nouveau_range_fault() now uses hmm_range_fault_unlocked_timeout() for > the HMM fault path. The timeout passed to that helper is meant to bound > HMM's internal mmu-notifier retry loop, not the whole nouveau retry loop > around mmu_interval_read_retry(). > > Pass the full relative HMM_RANGE_DEFAULT_TIMEOUT value to > hmm_range_fault_unlocked_timeout() on each attempt, and retry from the > nouveau-side mmu_interval_read_retry() check with a fresh HMM retry > budget. This lets HMM continue when it has made progress, while still > preserving a timeout for repeated notifier invalidation retries inside > one HMM fault attempt. > > This also removes the open-coded absolute deadline and remaining-time > calculation from nouveau_range_fault(). [Severity: Medium] Is this description meant for a different patch? The commit message describes changes to nouveau_range_fault() and the nouveau driver, but the actual patch modifies aie2_populate_range() in the amdxdna driver. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/178405975214.1082778.5193079941156341151.stgit@skinsburskii?part=3
