Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] The `memory-region` alternative is completely broken due to conflicting top-level `required` constraints and a missing property definition. --
--- Patch [1]: [PATCH v2 1/6] dt-bindings: display: add a device tree supplied boot logo --- commit f24f24c36e68703fb2282044b3ecdd6fe92fa5c4 Author: Max Pedraza <[email protected]> dt-bindings: display: add a device tree supplied boot logo Embedded products frequently need a product specific boot logo. This commit adds a binding for a "linux,boot-logo-clut224" node to allow the boot logo to be described by the device tree instead of baked into the kernel. The image can live in the device tree directly or in a reserved memory region. > diff --git > a/Documentation/devicetree/bindings/display/linux,boot-logo-clut224.yaml > b/Documentation/devicetree/bindings/display/linux,boot-logo-clut224.yaml > new file mode 100644 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/linux,boot-logo-clut224.yaml [ ... ] > +required: > + - compatible > + - width > + - height > + - clut > + - data [Severity: Medium] Does this global required block conflict with the oneOf block below? Since width, height, clut, and data are unconditionally required here, any node attempting to use the memory-region alternative will fail schema validation because it lacks these globally required properties. > + > +# The image either lives in the device tree or in a reserved memory region, > +# never both. > +oneOf: > + - required: > + - width > + - height > + - clut > + - data > + - required: > + - memory-region > + > +additionalProperties: false [Severity: Medium] Can this schema successfully validate a node using a memory-region? Since memory-region is missing from the main properties block, setting additionalProperties to false here will cause validation to reject any node that includes it, completely preventing this configuration alternative from being used. -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=1
