Thank you for your contribution! Sashiko AI review found 1 potential issue(s)
to consider:
- [Medium] The conditional `if` block for the new Eliza HDMI TX device uses an
incorrect compatible string with a duplicated vendor prefix
('qcom,qcom,eliza-hdmi-tx'), preventing the schema constraints from being
applied.
--
commit 95836f68df5245b7dc121437b6c3df3442b5e4f8
Author: Krzysztof Kozlowski <[email protected]>
dt-bindings: display/msm: hdmi: Add Eliza HDMI TX
Qualcomm Eliza SoC comes with HDMI IP block, built on top of one
previously present in MSM8998. There are just a few differences in
hardware, mostly about handling clock reparenting, but more notable the
old binding looked incomplete, thus devices could not be considered
compatible.
> diff --git a/Documentation/devicetree/bindings/display/msm/hdmi.yaml
> b/Documentation/devicetree/bindings/display/msm/hdmi.yaml
> index 02d27ccad0247..6adaa095b7473 100644
> --- a/Documentation/devicetree/bindings/display/msm/hdmi.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/hdmi.yaml
[ ... ]
> @@ -159,6 +180,44 @@ allOf:
> - const: bus
> - const: mnoc
> - const: iface_mmss
> + reg-names:
> + minItems: 1
> + items:
> + - const: core_physical
> + - const: qfprom_physical
> + - const: hdcp_physical
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - qcom,qcom,eliza-hdmi-tx
[Severity: Medium]
Does this compatible string contain a duplicated "qcom," vendor prefix?
It appears that this should be "qcom,eliza-hdmi-tx" to match the compatible
string defined in the properties section and the example. With the duplicated
prefix, this conditional block will not match, causing the constraints for the
clocks, reg, and required properties defined in the "then" block to be
bypassed during dtbs schema validation.
> + then:
> + properties:
> + clocks:
> + minItems: 6
> + maxItems: 6
--
Sashiko AI review ยท
https://sashiko.dev/#/patchset/[email protected]?part=5
