On Fri, 28 Aug 2026, Krzysztof Niemiec <[email protected]> wrote: >> @@ -34,6 +36,7 @@ >> #include "gt/intel_gpu_commands.h" >> #include "gt/intel_gtt.h" >> >> +#include "../i915_drv.h" > > Is the ../ really necessary here? It builds for me if i just switch to > #include "i915_drv.h", other includes treat driver/gpu/drm/i915 as the > working dir. I've seen both styles used in the selftests but it just > looks a bit out of place here.
Using ../ is generally just the plain wrong thing to do. >> diff --git a/drivers/gpu/drm/i915/selftests/i915_perf.c >> b/drivers/gpu/drm/i915/selftests/i915_perf.c >> index e9469e27f42a..d2a1a901d47b 100644 >> --- a/drivers/gpu/drm/i915/selftests/i915_perf.c >> +++ b/drivers/gpu/drm/i915/selftests/i915_perf.c >> @@ -14,6 +14,8 @@ >> #include "igt_flush_test.h" >> #include "lib_sw_fence.h" >> >> +#include <drm/drm_print.h> >> + > > Giga nit, but should this be before the "" includes? It's not even a nit. That's the style that should be adhered to in the driver. BR, Jani. -- Jani Nikula, Intel
