On 2026-09-01 at 14:50 +1000, Dave Airlie <[email protected]> wrote... > > > > > > We should make the NovaCoreApi just provide an accessor for &Spec and > > > make every > > > subsequent method we need public. Otherwise we end up with endless > > > forwarding > > > methods. We can also add as_raw() methods to the specific types as needed. > > > > Ok. This is where I don't have a good instinct for what we think should be > > an > > accessor/forwarding method vs. where we should just expose the underlying > > data > > structure and required methods to API users. > > > > In the past it seems there's been some resistance to exposing nova-core or > > gsp > > data structures like this which is why I added the forwarding methods. In > > future > > we're going to have other data-structures that NovaCoreApi will need to > > access > > so it would be good to understand what we should do here so we can keep > > things > > somewhat consistent. > > We can expose structure defined in nova-core, we cannot expose > structures defined in gsp bindings or firmware.
All the fields of self.gpu are structures defined as rust native structures in nova-core. Their values may be decoded or derived from GSP responses, but by design none of the raw structures from gsp bindings live in self.gpu AFAIK. - Alistair > In theory we can internally between core/drm but I'd really really > like to keep that boundary as the limits of GSP for auditability > purposes. > > Dave.
