Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] Device tree schema conflict for the 'novatek,nt36672a-ts' compatible string causes `dtbs_check` validation failures. --
commit d198703693d9ad88fe332afc5287a4b5bb64a630 Author: YİĞİTCAN KAVAKLI <[email protected]> dt-bindings: input: touchscreen: add Novatek NT36672A SPI touchscreen Add devicetree binding documentation for the Novatek NT36672A SPI touchscreen controller. > diff --git > a/Documentation/devicetree/bindings/input/touchscreen/novatek,nt36672a-spi.yaml > > b/Documentation/devicetree/bindings/input/touchscreen/novatek,nt36672a-spi.yaml > index 0000000000000..0d89d60f2a93d > --- /dev/null > +++ > b/Documentation/devicetree/bindings/input/touchscreen/novatek,nt36672a-spi.yaml [ ... ] > +properties: > + compatible: > + enum: > + - novatek,nt36672a-spi > + - novatek,nt36672a-ts [Severity: Low] Does adding "novatek,nt36672a-ts" here conflict with the existing I2C binding in novatek,nvt-ts.yaml? Since "novatek,nt36672a-ts" is already bound to the I2C schema, and both schemas define unevaluatedProperties: false without a custom select rule based on the parent bus, nodes with this compatible string will match both schemas simultaneously. Will this cause dtbs_check validation to fail for existing I2C touchscreens (which lack SPI properties like spi-max-frequency) and new SPI touchscreens (which lack I2C properties like vcc-supply)? -- Sashiko AI review · https://sashiko.dev/#/patchset/[email protected]?part=5
