On 26-09-13 21:18:34, Srinivas Kandagatla wrote: > Introduce a device tree for the Mahua-based Lenovo ThinkPad T14s Gen 7, > a Snapdragon X2 Elite laptop. It follows the Qualcomm Glymur reference > design used by mahua-crd. > > Currently working: > - Display (internal eDP panel) > - Audio playback and capture (2x WSA8845 speakers on swr0, DMICs via > the VA macro) > - USB-C (host + charging on both ports) > - Wi-Fi (WCN7850 on PCIe4), Bluetooth (over uart14) > - NVMe on PCIe5 > - HID-over-I2C touchpad, keyboard and TrackPoint on i2c0 > - Lid switch > - WWAN wiring is included but remains untested due to lack of access > to such a SKU. > > Assisted-by: Claude:claude-opus-4-7 > Signed-off-by: Srinivas Kandagatla <[email protected]>
One minor nit below. Anyway, LGTM so: Reviewed-by: Abel Vesa <[email protected]> > --- > arch/arm64/boot/dts/qcom/Makefile | 1 + > .../qcom/mahua-lenovo-thinkpad-t14s-gen7.dts | 1184 +++++++++++++++++ > 2 files changed, 1185 insertions(+) > create mode 100644 > arch/arm64/boot/dts/qcom/mahua-lenovo-thinkpad-t14s-gen7.dts > > diff --git a/arch/arm64/boot/dts/qcom/Makefile > b/arch/arm64/boot/dts/qcom/Makefile > index 6c2ac11133ca..c71d536fc3e7 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -59,6 +59,7 @@ dtb-$(CONFIG_ARCH_QCOM) += lemans-evk-el2.dtb > lemans-evk-ifp-mezzanine-dtbs := lemans-evk.dtb > lemans-evk-ifp-mezzanine.dtbo > dtb-$(CONFIG_ARCH_QCOM) += lemans-evk-ifp-mezzanine.dtb > dtb-$(CONFIG_ARCH_QCOM) += mahua-crd.dtb > +dtb-$(CONFIG_ARCH_QCOM) += mahua-lenovo-thinkpad-t14s-gen7.dtb > dtb-$(CONFIG_ARCH_QCOM) += milos-fairphone-fp6.dtb > dtb-$(CONFIG_ARCH_QCOM) += milos-nothing-asteroids.dtb > dtb-$(CONFIG_ARCH_QCOM) += monaco-arduino-monza.dtb > diff --git a/arch/arm64/boot/dts/qcom/mahua-lenovo-thinkpad-t14s-gen7.dts > b/arch/arm64/boot/dts/qcom/mahua-lenovo-thinkpad-t14s-gen7.dts > new file mode 100644 > index 000000000000..be5f12bfe56a > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/mahua-lenovo-thinkpad-t14s-gen7.dts > @@ -0,0 +1,1184 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. > + */ > +/dts-v1/; > + > +#include "mahua.dtsi" > + [...] > + > + reserved-memory { > + linux,cma { > + compatible = "shared-dma-pool"; > + size = <0x0 0x10000000>; > + reusable; > + linux,cma-default; > + }; > + }; > + > + Nit: Drop this extra line. > + sound { > + compatible = "qcom,glymur-sndcard"; > + model = "Lenovo-ThinkPad-T14s-Gen-7"; > + audio-routing = "SpkrLeft IN", "WSA WSA_SPK1 OUT", > + "SpkrRight IN", "WSA WSA_SPK2 OUT", > + "VA DMIC0", "vdd-micb", > + "VA DMIC1", "vdd-micb"; > + > + wsa-dai-link { > + link-name = "WSA Playback"; > + > + cpu { > + sound-dai = <&q6apmbedai WSA_CODEC_DMA_RX_0>; > + }; > + > + codec { > + sound-dai = <&left_spk>, <&right_spk>, > + <&swr0 0>, <&lpass_wsamacro 0>; > + }; > + > + platform { > + sound-dai = <&q6apm>; > + }; > + }; > + > + va-dai-link { > + link-name = "VA Capture"; > + > + cpu { > + sound-dai = <&q6apmbedai VA_CODEC_DMA_TX_0>; > + }; > + > + codec { > + sound-dai = <&lpass_vamacro 0>; > + }; > + > + platform { > + sound-dai = <&q6apm>; > + }; > + }; > + }; > +
