On 9/13/26 10:18 PM, Srinivas Kandagatla wrote:
> Introduce a device tree for the Mahua-based Lenovo ThinkPad T14s Gen 7,
> a Snapdragon X2 Elite laptop. It follows the Qualcomm Glymur reference
> design used by mahua-crd.
[...]
> + vreg_edp_3p3: regulator-edp-3p3 {
nit: please sort the regulator nodes based on their names
[...]
> + reserved-memory {
> + linux,cma {
> + compatible = "shared-dma-pool";
> + size = <0x0 0x10000000>;
> + reusable;
> + linux,cma-default;
> + };
> + };
> +
> +
> + sound {
Stray double \n above
[...]
> + vreg_l18b_e0_1p2: ldo18 {
> + regulator-name = "vreg_l18b_e0_1p2";
> + regulator-min-microvolt = <1200000>;
> + regulator-max-microvolt = <1200000>;
> + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> + regulator-always-on;
> + };
xxx
[...]
> +&i2c5 {
> + clock-frequency = <400000>;
> +
> + status = "okay";
> +
> + /* eUSB2 redriver for USB Type-A ports on the MultiPort controller */
nit: this comment seems self-explanatory
[...]
> +/* Internal eDP panel */
Likewise, it says so a couple lines below
[...]
> +&remoteproc_soccp {
> + status = "okay";
> +};
This is always enabled
[...]
> +/* Two internal USB Type-A ports through the MultiPort host controller */
I think the right thing to describe here is what they connect to
lg otherwise
Konrad
