Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] The `mdio0` block containing the `phy0` and `phy1` node definitions was accidentally deleted during indentation cleanup, resulting in unresolved phandle references. --
commit 3067fd6538b78515dc2a63a2028de505854e6496 Author: Krzysztof Kozlowski <[email protected]> dt-bindings: net: Use consistent indentation in the example This patch corrects the indentation in various device tree binding examples to conform to a consistent 2- or 4-space indent style. It aims to resolve dt-check-style warnings across multiple net and wireless bindings files. > diff --git > a/Documentation/devicetree/bindings/net/cortina,gemini-ethernet.yaml > b/Documentation/devicetree/bindings/net/cortina,gemini-ethernet.yaml > index f0b5bea2458d5..da9bc170cd543 100644 > --- a/Documentation/devicetree/bindings/net/cortina,gemini-ethernet.yaml > +++ b/Documentation/devicetree/bindings/net/cortina,gemini-ethernet.yaml > @@ -87,18 +87,6 @@ examples: > #include <dt-bindings/interrupt-controller/irq.h> > #include <dt-bindings/clock/cortina,gemini-clock.h> > #include <dt-bindings/reset/cortina,gemini-reset.h> > - mdio0: mdio { > - #address-cells = <1>; > - #size-cells = <0>; > - phy0: ethernet-phy@1 { > - reg = <1>; > - device_type = "ethernet-phy"; > - }; > - phy1: ethernet-phy@3 { > - reg = <3>; > - device_type = "ethernet-phy"; > - }; > - }; [Severity: Low] Does the removal of this mdio0 block break the device tree example compilation? Since phy-handle = <&phy0>; and phy-handle = <&phy1>; are still used later in the gmac0 and gmac1 nodes, deleting these target nodes results in unresolved phandles when running make dt_binding_check. Was this block accidentally dropped during the indentation cleanup? > > ethernet@60000000 { > compatible = "cortina,gemini-ethernet"; > @@ -110,28 +98,28 @@ examples: > ranges; > > gmac0: ethernet-port@0 { > - compatible = "cortina,gemini-ethernet-port"; > - reg = <0x60008000 0x2000>, /* Port 0 DMA/TOE */ > - <0x6000a000 0x2000>; /* Port 0 GMAC */ > - interrupt-parent = <&intcon>; > - interrupts = <1 IRQ_TYPE_LEVEL_HIGH>; > - resets = <&syscon GEMINI_RESET_GMAC0>; > - clocks = <&syscon GEMINI_CLK_GATE_GMAC0>; > - clock-names = "PCLK"; > - phy-mode = "rgmii"; > - phy-handle = <&phy0>; > + compatible = "cortina,gemini-ethernet-port"; > + reg = <0x60008000 0x2000>, /* Port 0 DMA/TOE */ > + <0x6000a000 0x2000>; /* Port 0 GMAC */ > + interrupt-parent = <&intcon>; > + interrupts = <1 IRQ_TYPE_LEVEL_HIGH>; > + resets = <&syscon GEMINI_RESET_GMAC0>; > + clocks = <&syscon GEMINI_CLK_GATE_GMAC0>; > + clock-names = "PCLK"; > + phy-mode = "rgmii"; > + phy-handle = <&phy0>; > }; -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
