Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] drm/fourcc: typo 'Unlinke' instead of 'Unlike' in UAPI comment --
commit 5f845c0015bd5ad4e49e23a58d6607e8d2cac4d3 Author: James Calligeros <[email protected]> drm/fourcc: Add Apple Interchange layout format modifier This commit adds a format modifier for the Apple Interchange layout to allow buffer exchange between Apple hardware blocks. > diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h > --- a/include/uapi/drm/drm_fourcc.h > +++ b/include/uapi/drm/drm_fourcc.h [ ... ] > @@ -1626,6 +1626,26 @@ drm_fourcc_canonicalize_nvidia_format_mod(__u64 > modifier) > #define DRM_FORMAT_MOD_APPLE_GPU_TILED fourcc_mod_code(APPLE, 1) > #define DRM_FORMAT_MOD_APPLE_GPU_TILED_COMPRESSED fourcc_mod_code(APPLE, 2) > > +/* > + * Apple Interchange layout > + * > + * Apple Interchange is a compressed framebuffer format used exclusively for > + * sharing buffers between hardware blocks (GPU, display controller, video > + * codecs) on Apple platforms. It is similar to and uses the same compression > + * scheme as GPU_TILED_COMPRESSED. There is no known uncompressed variant > + * of Apple Interchange. > + * > + * Unlinke the GPU layouts, tile size is not dependent on bit depth. RGB [Severity: Low] There is a typo in the documentation comment for DRM_FORMAT_MOD_APPLE_INTERCHANGE here. Unlinke should be Unlike. > + * images and the chroma components of YUV images use 16x16 tiles. The > + * luma component of YUV images uses 32x32 tiles. Compression tiles [ ... ] -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
