Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] drm/loongson: missed vga_client_register API conversion breaks build --
commit 53a905b209a5cf4aa1aeb17a42069c191d47a151 Author: Dave Airlie <[email protected]> pci/vgaarb: pass a data pointer to be used in the decode callback This commit updates the vga_client_register() API to accept a void *data pointer, which is then passed to the decode callback. It also updates various DRM drivers and VFIO to pass and use this new private data pointer. [ ... ] > diff --git a/include/linux/vgaarb.h b/include/linux/vgaarb.h > index 97129a1bbb7df..71a364669eaf8 100644 > --- a/include/linux/vgaarb.h > +++ b/include/linux/vgaarb.h > @@ -33,7 +33,8 @@ struct pci_dev *vga_default_device(void); > void vga_set_default_device(struct pci_dev *pdev); > int vga_remove_vgacon(struct pci_dev *pdev); > int vga_client_register(struct pci_dev *pdev, > - unsigned int (*set_decode)(struct pci_dev *pdev, bool state)); > + unsigned int (*set_decode)(void *data, bool state), > + void *data); [Severity: Low] Does this API change break the build for the loongson DRM driver? It looks like the conversion of vga_client_register() missed lsdc_pci_probe() in drivers/gpu/drm/loongson/lsdc_drv.c: drivers/gpu/drm/loongson/lsdc_drv.c:lsdc_pci_probe() { ... vga_client_register(pdev, lsdc_vga_set_decode); ... } The callback lsdc_vga_set_decode() also still expects a struct pci_dev * rather than void *data. [ ... ] -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
