Hi Dave,

kernel test robot noticed the following build errors:

[auto build test ERROR on drm-misc/drm-misc-next]
[also build test ERROR on pci/next pci/for-linus drm-tip/drm-tip linus/master 
v7.3-rc4 next-20260922]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    
https://github.com/intel-lab-lkp/linux/commits/Dave-Airlie/pci-vgaarb-pass-a-data-pointer-to-be-used-in-the-decode-callback/20260922-164111
base:   https://gitlab.freedesktop.org/drm/misc/kernel.git drm-misc-next
patch link:    
https://lore.kernel.org/r/20260922064111.2468741-1-airlied%40gmail.com
patch subject: [PATCH] pci/vgaarb: pass a data pointer to be used in the decode 
callback
config: csky-allmodconfig 
(https://download.01.org/0day-ci/archive/20260924/[email protected]/config)
compiler: csky-linux-gcc (GCC) 16.1.0
reproduce (this is a W=1 build): 
(https://download.01.org/0day-ci/archive/20260924/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: 
https://lore.kernel.org/oe-kbuild-all/[email protected]/

All errors (new ones prefixed by >>):

   drivers/gpu/drm/loongson/lsdc_drv.c: In function 'lsdc_pci_probe':
   drivers/gpu/drm/loongson/lsdc_drv.c:294:35: error: passing argument 2 of 
'vga_client_register' from incompatible pointer type 
[-Wincompatible-pointer-types]
     294 |         vga_client_register(pdev, lsdc_vga_set_decode);
         |                                   ^~~~~~~~~~~~~~~~~~~
         |                                   |
         |                                   unsigned int (*)(struct pci_dev *, 
bool) {aka unsigned int (*)(struct pci_dev *, _Bool)}
   In file included from drivers/gpu/drm/loongson/lsdc_drv.c:8:
   include/linux/vgaarb.h:36:32: note: expected 'unsigned int (*)(void *, 
bool)' {aka 'unsigned int (*)(void *, _Bool)'} but argument is of type 
'unsigned int (*)(struct pci_dev *, bool)' {aka 'unsigned int (*)(struct 
pci_dev *, _Bool)'}
      36 |                 unsigned int (*set_decode)(void *data, bool state),
         |                 ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/loongson/lsdc_drv.c:257:21: note: 'lsdc_vga_set_decode' 
declared here
     257 | static unsigned int lsdc_vga_set_decode(struct pci_dev *pdev, bool 
state)
         |                     ^~~~~~~~~~~~~~~~~~~
>> drivers/gpu/drm/loongson/lsdc_drv.c:294:9: error: too few arguments to 
>> function 'vga_client_register'; expected 3, have 2
     294 |         vga_client_register(pdev, lsdc_vga_set_decode);
         |         ^~~~~~~~~~~~~~~~~~~
   include/linux/vgaarb.h:35:5: note: declared here
      35 | int vga_client_register(struct pci_dev *pdev,
         |     ^~~~~~~~~~~~~~~~~~~


vim +/vga_client_register +294 drivers/gpu/drm/loongson/lsdc_drv.c

f39db26c54281d Sui Jingfeng      2023-06-15  261  
f39db26c54281d Sui Jingfeng      2023-06-15  262  static int 
lsdc_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
f39db26c54281d Sui Jingfeng      2023-06-15  263  {
f39db26c54281d Sui Jingfeng      2023-06-15  264        const struct lsdc_desc 
*descp;
f39db26c54281d Sui Jingfeng      2023-06-15  265        struct drm_device *ddev;
f39db26c54281d Sui Jingfeng      2023-06-15  266        struct lsdc_device 
*ldev;
f39db26c54281d Sui Jingfeng      2023-06-15  267        int ret;
f39db26c54281d Sui Jingfeng      2023-06-15  268  
f39db26c54281d Sui Jingfeng      2023-06-15  269        descp = 
lsdc_device_probe(pdev, ent->driver_data);
f39db26c54281d Sui Jingfeng      2023-06-15  270        if 
(IS_ERR_OR_NULL(descp))
f39db26c54281d Sui Jingfeng      2023-06-15  271                return -ENODEV;
f39db26c54281d Sui Jingfeng      2023-06-15  272  
f39db26c54281d Sui Jingfeng      2023-06-15  273        pci_set_master(pdev);
f39db26c54281d Sui Jingfeng      2023-06-15  274  
f39db26c54281d Sui Jingfeng      2023-06-15  275        ret = 
dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(40));
f39db26c54281d Sui Jingfeng      2023-06-15  276        if (ret)
f39db26c54281d Sui Jingfeng      2023-06-15  277                return ret;
f39db26c54281d Sui Jingfeng      2023-06-15  278  
f39db26c54281d Sui Jingfeng      2023-06-15  279        ret = 
pcim_enable_device(pdev);
f39db26c54281d Sui Jingfeng      2023-06-15  280        if (ret)
f39db26c54281d Sui Jingfeng      2023-06-15  281                return ret;
f39db26c54281d Sui Jingfeng      2023-06-15  282  
f39db26c54281d Sui Jingfeng      2023-06-15  283        dev_info(&pdev->dev, 
"Found %s, revision: %u",
f39db26c54281d Sui Jingfeng      2023-06-15  284                 
to_loongson_gfx(descp)->model, pdev->revision);
f39db26c54281d Sui Jingfeng      2023-06-15  285  
f39db26c54281d Sui Jingfeng      2023-06-15  286        ldev = 
lsdc_create_device(pdev, descp, &lsdc_drm_driver);
f39db26c54281d Sui Jingfeng      2023-06-15  287        if (IS_ERR(ldev))
f39db26c54281d Sui Jingfeng      2023-06-15  288                return 
PTR_ERR(ldev);
f39db26c54281d Sui Jingfeng      2023-06-15  289  
f39db26c54281d Sui Jingfeng      2023-06-15  290        ddev = &ldev->base;
f39db26c54281d Sui Jingfeng      2023-06-15  291  
f39db26c54281d Sui Jingfeng      2023-06-15  292        pci_set_drvdata(pdev, 
ddev);
f39db26c54281d Sui Jingfeng      2023-06-15  293  
f39db26c54281d Sui Jingfeng      2023-06-15 @294        
vga_client_register(pdev, lsdc_vga_set_decode);
f39db26c54281d Sui Jingfeng      2023-06-15  295  
0a9c56dd387605 Myeonghun Pak     2026-05-13  296        
drmm_kms_helper_poll_init(ddev);
f39db26c54281d Sui Jingfeng      2023-06-15  297  
f39db26c54281d Sui Jingfeng      2023-06-15  298        if (loongson_vblank) {
f39db26c54281d Sui Jingfeng      2023-06-15  299                ret = 
drm_vblank_init(ddev, descp->num_of_crtc);
f39db26c54281d Sui Jingfeng      2023-06-15  300                if (ret)
f39db26c54281d Sui Jingfeng      2023-06-15  301                        return 
ret;
f39db26c54281d Sui Jingfeng      2023-06-15  302  
f39db26c54281d Sui Jingfeng      2023-06-15  303                ret = 
devm_request_irq(&pdev->dev, pdev->irq,
f39db26c54281d Sui Jingfeng      2023-06-15  304                                
       descp->funcs->irq_handler,
f39db26c54281d Sui Jingfeng      2023-06-15  305                                
       IRQF_SHARED,
f39db26c54281d Sui Jingfeng      2023-06-15  306                                
       dev_name(&pdev->dev), ddev);
f39db26c54281d Sui Jingfeng      2023-06-15  307                if (ret) {
f39db26c54281d Sui Jingfeng      2023-06-15  308                        
drm_err(ddev, "Failed to register interrupt: %d\n", ret);
f39db26c54281d Sui Jingfeng      2023-06-15  309                        return 
ret;
f39db26c54281d Sui Jingfeng      2023-06-15  310                }
f39db26c54281d Sui Jingfeng      2023-06-15  311  
f39db26c54281d Sui Jingfeng      2023-06-15  312                drm_info(ddev, 
"registered irq: %u\n", pdev->irq);
f39db26c54281d Sui Jingfeng      2023-06-15  313        }
f39db26c54281d Sui Jingfeng      2023-06-15  314  
f39db26c54281d Sui Jingfeng      2023-06-15  315        ret = 
drm_dev_register(ddev, 0);
f39db26c54281d Sui Jingfeng      2023-06-15  316        if (ret)
f39db26c54281d Sui Jingfeng      2023-06-15  317                return ret;
f39db26c54281d Sui Jingfeng      2023-06-15  318  
4269f5c878fc19 Thomas Zimmermann 2024-09-24  319        drm_client_setup(ddev, 
NULL);
f39db26c54281d Sui Jingfeng      2023-06-15  320  
f39db26c54281d Sui Jingfeng      2023-06-15  321        return 0;
f39db26c54281d Sui Jingfeng      2023-06-15  322  }
f39db26c54281d Sui Jingfeng      2023-06-15  323  

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Reply via email to