> Integrate userptr into the blob resource creation ioctl. > > - A non-zero userptr selects virtio_gpu_userptr_create() > - Reject userptr unless blob_mem is VIRTGPU_BLOB_MEM_GUEST > - Reject VIRTGPU_BLOB_FLAG_USE_READONLY unless the device > advertised VIRTIO_GPU_F_BLOB_READONLY > - Advertise VIRTGPU_PARAM_USERPTR and VIRTGPU_PARAM_BLOB_READONLY > - Add VIRTIO_GPU_F_BLOB_READONLY to the driver's features[] array > > virtio_has_feature() routes device-specific feature bits through > virtio_check_driver_offered_feature(), which calls BUG() when the > driver queries a bit it never declared in features[]. The > VIRTIO_GPU_F_BLOB_READONLY probe added to virtio_gpu_init() hit > exactly that: every probe crashed regardless of host support because > the bit was missing from features[]. Registering it there fixes the > crash. > > Signed-off-by: Honglei Huang <[email protected]>
Sashiko has reviewed this patch and found no issues. It looks great! -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=4
