On Tue, 2026-09-29 at 16:18 +0000, [email protected] wrote: > Thank you for your contribution! Sashiko AI review found 2 potential issue(s) > to consider: > - [Low] drm/xe: commit message describes dropped design changes > - [Low] drm/xe: preprocessor macro defined inside function body > -- > alan:snip > [Severity: Medium] > This isn't a bug introduced by this patch, but __xe_mmio_wait32 is called > with wait values that can reach 100,000 microseconds (100ms) due to the > backoff limit. According to the kernel timer guidelines, usleep_range > should only be used for delays under 20ms, while msleep is recommended > for larger delays to avoid using high-overhead hrtimers. Could we switch > to msleep for the longer iterations? > alan: I cant find this mention of "kernel timer guidelines, usleep_range should only be used for delays under 20ms" in fact linux kernel documentation explicitly states that uslee_range is good for both short and long delays: https://docs.kernel.org/timers/delay_sleep_functions.html Thus, will ignore this one.
Will fix the other low priority feedback. alan:snip
