On Thu, Oct 01, 2026 at 11:59:32AM +0000, [email protected] wrote: > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) > to consider: > - [Low] doc: repeated sentence in disable_acs_redir description > -- > > commit 83321a8abe2362759f10e2c9273854fa000319e6 > Author: Leon Romanovsky <[email protected]> > > PCI/P2PDMA: Document directional ACS routing > > P2PDMA documentation describes ACS controls as path-wide, although Request > and Completion controls apply to different transaction directions. This > commit documents the fixed client and provider roles, the divergence port > checked, and clarifies which controls disable_acs_redir changes. > > > diff --git a/Documentation/admin-guide/kernel-parameters.txt > > b/Documentation/admin-guide/kernel-parameters.txt > > index 68647ff4bdd24..bc83e07dd5fce 100644 > > --- a/Documentation/admin-guide/kernel-parameters.txt > > +++ b/Documentation/admin-guide/kernel-parameters.txt > > @@ -5291,12 +5291,15 @@ Kernel parameters > > disable_acs_redir=<pci_dev>[; ...] > > Specify one or more PCI devices (in the format > > specified above) separated by semicolons. > > - Each device specified will have the PCI ACS > > - redirect capabilities forced off which will > > - allow P2P traffic between devices through > > - bridges without forcing it upstream. Note: > > - this removes isolation between devices and > > - may put more devices in an IOMMU group. > > + Each device specified will have the PCI ACS P2P > > + Request Redirect, Completion Redirect, and > > Egress > > + Control features forced off. This may allow P2P > > + traffic through bridges that would otherwise be > > + redirected upstream. This may allow P2P traffic > > + through bridges that would otherwise be > > redirected > > [Severity: Low] > This isn't a bug, but there is a repeated sentence ("This may allow P2P > traffic through bridges that would otherwise be redirected upstream.") in > this block.
Right, copy/paste error. Bjorn, should I resend? Thanks > > > + upstream and thus this removes isolation between > > + devices and may cause affected devices to share > > + an IOMMU group. > > -- > Sashiko AI review ยท > https://sashiko.dev/#/patchset/[email protected]?part=5
