Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [Medium] dt-bindings: missing 'pwms' property for PWM input - [Low] dt-bindings: missing power supply property --
commit bdcbdabe3e1453e58fc8f39fabc82b20db81480c Author: Luka Panio <[email protected]> dt-bindings: leds: backlight: Add Awinic AW99703 backlight The Awinic AW99703 is a 3-string WLED driver converter with an integrated boost converter and 11-bit brightness control over I2C, optionally combined with a PWM input. > diff --git > a/Documentation/devicetree/bindings/leds/backlight/awinic,aw99703.yaml > b/Documentation/devicetree/bindings/leds/backlight/awinic,aw99703.yaml > new file mode 100644 > index 0000000000000..62e8cc3118f2e > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/backlight/awinic,aw99703.yaml > @@ -0,0 +1,131 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/leds/backlight/awinic,aw99703.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Awinic AW99703 WLED Backlight Driver > + > +maintainers: > + - Luka Panio <[email protected]> > + > +description: > + The AW99703 is a 3-string WLED driver with an integrated boost converter > + and 11-bit I2C (optionally PWM) brightness control. > + > +allOf: > + - $ref: common.yaml# > + > +properties: > + compatible: > + const: awinic,aw99703 [Severity: Low] Is a power supply property needed for the boost converter? The hardware has an integrated boost converter, which typically requires a supply such as 'vin-supply' or 'vcc-supply'. Because the schema enforces 'unevaluatedProperties: false', boards with a controllable regulator powering the backlight will fail schema validation if they attempt to define it. [ ... ] > + awinic,inductor-nanohenry: > + description: Boost inductor value. > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [4700, 10000] > + default: 4700 > + > + awinic,pwm-input: > + description: Combine the PWM input pin with the I2C brightness. > + type: boolean [Severity: Medium] Should the standard 'pwms' property be defined alongside this property? The schema defines 'awinic,pwm-input' to indicate the hardware uses a PWM input pin, but it doesn't define the standard 'pwms' property. Since this schema uses 'unevaluatedProperties: false', board device trees attempting to properly link a PWM controller using 'pwms = <&pwm ...>;' will fail schema validation. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=1
