Hi Krzysztof, On Mon, Oct 19, 2026 at 9:02 AM Krzysztof Kozlowski <[email protected]> wrote: > > On Fri, Oct 16, 2026 at 06:29:11PM +0200, Luka Panio wrote: > > + awinic,iled-max-microamp: > > + description: > > + Full-scale current of each LED string, reached at the maximum > > + brightness code (and 100% PWM duty cycle if PWM dimming is used). > > + minimum: 4800 > > + maximum: 29600 > > + multipleOf: 800 > > + default: 20000 > > + > > + awinic,ramp-on-time-us: > > + description: Current sink ramp-up time when leaving standby. > > + enum: [512, 1000, 2000, 4000, 8000, 16000, 32000, 64000, 128000, > > + 256000, 512000, 1024000, 2048000, 4096000, 8192000, 16384000] > > + default: 8000 > > + > > + awinic,ramp-off-time-us: > > + description: Current sink ramp-down time when entering standby. > > + enum: [512, 1000, 2000, 4000, 8000, 16000, 32000, 64000, 128000, > > + 256000, 512000, 1024000, 2048000, 4096000, 8192000, 16384000] > > + default: 8000 > > + > > + awinic,pwm-trans-time-ms: > > + description: > > + Transition time between brightness levels set by the PWM input, > > + for a change over the full duty cycle range. > > + enum: [2, 4, 8, 16, 32, 64, 128, 256] > > + default: 2 > > Feels like you are re-implementing triggers. Several properties actually > feel duplicating standard LED ones. > Thanks for the review. Agreed, the ramp/transition timings and the mapping mode are not really hardware descriptions. In v2 I'll drop them and leave the chip defaults, and switch to the standard led-sources and led-max-microamp properties instead of awinic,led-strings and awinic,iled-max-microamp.
> > + > > + awinic,i2c-trans-time-ms: > > + description: > > + Fixed transition time between brightness levels set over I2C, > > + independent of the size of the change. When absent the brightness > > + ramps with a fixed slope of 1 us per brightness code instead. > > + enum: [128, 192, 256, 320, 384, 448, 512, 576, 640, 768, 1024, 1280, > > + 1536, 2560, 4096] > > Best regards, > Krzysztof > Thanks, Luka
