Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] drm/tegra: missing DRM_FORMAT_YVU422 in tegra_shared_plane_formats[] --
commit e7e49e62ddbbdc37f4015e827f67d01e9ee20c45 Author: Aaron Kling <[email protected]> drm/tegra: Support YVU formats This commit adds support for the YVU420, YVU422, and YVU444 pixel formats to the Tegra DRM plane and display controller drivers by mapping them to the corresponding YCbCr planar formats with UV plane swapping enabled. > diff --git a/drivers/gpu/drm/tegra/hub.c b/drivers/gpu/drm/tegra/hub.c > index 5a86f8260f136..46756c749e674 100644 > --- a/drivers/gpu/drm/tegra/hub.c > +++ b/drivers/gpu/drm/tegra/hub.c > @@ -51,6 +51,7 @@ static const u32 tegra_shared_plane_formats[] = { > DRM_FORMAT_YUYV, > DRM_FORMAT_YUV420, > DRM_FORMAT_YUV422, > + DRM_FORMAT_YVU420, > }; [Severity: Medium] Should DRM_FORMAT_YVU422 also be included in tegra_shared_plane_formats[]? The commit message notes that YVU422 and YVU444 are added where supported, and tegra_shared_plane_formats[] already includes DRM_FORMAT_YUV422. In drivers/gpu/drm/tegra/plane.c, tegra_plane_format() translates DRM_FORMAT_YVU422 to WIN_COLOR_DEPTH_YCbCr422P with swap_uv set to true, and tegra_shared_plane_atomic_update() in drivers/gpu/drm/tegra/hub.c programs SWAP_UV in DC_WIN_PRECOMP_WGRP_PARAMS. Without DRM_FORMAT_YVU422 in tegra_shared_plane_formats[], commits or format queries for DRM_FORMAT_YVU422 on shared planes created via tegra_shared_plane_create() will be rejected by drm_plane_check_pixel_format(). -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=2
