On Mon, Oct 26, 2026 at 01:48:32PM +0530, himanshu bakshi wrote: > From: Himanshu Bakshi <[email protected]> > > fbtft_init_dbg is not used in drivers/staging/fbtft directory and > since dev_dbg messages are good enough, fbtft_init_dbg should be > removed. After compiling the driver, there are no undefined macro > issues.
This commit message is sort of acceptable but a better commit message would be: "The fbtft_init_dbg() macro is not used, so delete it." 1. () after the macro name to show it works as a function. 2. We care about the whole kernel not just drivers/staging/fbtft. 3. No need to discuss dev_dbg(). That is unrelated. 4. No need to discuss compiling the driver since that is assumed. Otherwise it looks fine. Reviewed-by: Dan Carpenter <[email protected]> regards, dan carpenter
