On Mon, Oct 26, 2026 at 2:21 PM Dan Carpenter <[email protected]> wrote: > This commit message is sort of acceptable but a better commit message > would be: > > "The fbtft_init_dbg() macro is not used, so delete it." > > 1. () after the macro name to show it works as a function. > 2. We care about the whole kernel not just drivers/staging/fbtft. > 3. No need to discuss dev_dbg(). That is unrelated. > 4. No need to discuss compiling the driver since that is assumed. > > Otherwise it looks fine. > > Reviewed-by: Dan Carpenter <[email protected]> > > regards, > dan carpenter
Hi Dan, Thank you so much for the review. I cannot find any call site for this macro in the overall kernel anywhere and hence it is safe to remove it. I have sent over the PATCH v2 with all the changes that you suggested and will be glad if you take a look at it. Thanks and regards, Himanshu Bakshi
