The positive and negative bias supplies of the NT36672E panel on the QCM6490 IDP board are switched on by the PM7250B GPIO2 bias enable signal, which is described as a single fixed regulator supplying both AVDD and AVEE bias supplies of the panel. The fixed regulator does not describe the hardware, it can not supply a positive and a negative voltage at the same time, and apparently bias supplies are generated right on the display panel module.
Since the panel binding supports the bias enable GPIO, describe the signal as such, and remove the oddly described and used fixed regulator. Signed-off-by: Vladimir Zapolskiy <[email protected]> --- arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts index af7821e02fdb..98bbe662bd3b 100644 --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts @@ -51,17 +51,6 @@ chosen { stdout-path = "serial0:115200n8"; }; - lcd_disp_bias: regulator-lcd-disp-bias { - compatible = "regulator-fixed"; - regulator-name = "lcd_disp_bias"; - regulator-min-microvolt = <5500000>; - regulator-max-microvolt = <5500000>; - gpio = <&pm7250b_gpios 2 GPIO_ACTIVE_HIGH>; - enable-active-high; - pinctrl-0 = <&lcd_disp_bias_en>; - pinctrl-names = "default"; - }; - gpio-keys { compatible = "gpio-keys"; @@ -653,14 +642,16 @@ panel@0 { compatible = "novatek,nt36672e"; reg = <0>; + enable-gpios = <&pm7250b_gpios 2 GPIO_ACTIVE_HIGH>; reset-gpios = <&tlmm 44 GPIO_ACTIVE_HIGH>; vddi-supply = <&vreg_l8c_1p62>; - avdd-supply = <&lcd_disp_bias>; - avee-supply = <&lcd_disp_bias>; backlight = <&pm8350c_pwm_backlight>; + pinctrl-0 = <&lcd_disp_bias_en>; + pinctrl-names = "default"; + port { panel0_in: endpoint { remote-endpoint = <&mdss_dsi0_out>; -- 2.51.0
