The test HDMI connector reset implementation creates a pristine state and initializes the HDMI state. It does not perform any hardware reset.
Since this is equivalent to what atomic_create_state expects, convert the reset function to an atomic_create_state hook that returns the initialized state. Signed-off-by: Maxime Ripard <[email protected]> --- drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c b/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c index 9953f5e661ce..336bb644cb7c 100644 --- a/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c +++ b/drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c @@ -200,16 +200,24 @@ static const struct drm_connector_helper_funcs dummy_connector_helper_funcs = { }; -static void dummy_hdmi_connector_reset(struct drm_connector *connector) +static struct drm_connector_state * +dummy_hdmi_connector_create_state(struct drm_connector *connector) { - drm_atomic_helper_connector_reset(connector); - __drm_atomic_helper_connector_hdmi_state_init(connector->state, + struct drm_connector_state *connector_state; + + connector_state = drm_atomic_helper_connector_create_state(connector); + if (IS_ERR(connector_state)) + return connector_state; + + __drm_atomic_helper_connector_hdmi_state_init(connector_state, connector); + + return connector_state; } static const struct drm_connector_funcs dummy_connector_funcs = { + .atomic_create_state = dummy_hdmi_connector_create_state, .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state, .fill_modes = drm_helper_probe_single_connector_modes, - .reset = dummy_hdmi_connector_reset, }; -- 2.55.0
