Hi Am 30.10.26 um 16:14 schrieb Maxime Ripard: [...]
+ connector_state = drm_atomic_helper_connector_create_state(connector); + if (IS_ERR(connector_state)) + return connector_state;
Somewhat unrelated to this series, this return statement made me think that we should consider requiring an ERR_CAST() in such situations. It documents what is happening and we're also not really returning a connector state.
Best regards Thomas
+ + __drm_atomic_helper_connector_hdmi_state_init(connector_state, connector); + + return connector_state; }static const struct drm_connector_funcs dummy_connector_funcs = {+ .atomic_create_state = dummy_hdmi_connector_create_state, .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state, .fill_modes = drm_helper_probe_single_connector_modes, - .reset = dummy_hdmi_connector_reset, };
-- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Stefan Gaiser, Jochen Jaser, Abhinav Puri, (HRB 36809, AG Nürnberg)
