On 04/11/2026 08:18, Philipp Stanner wrote:
On Tue, 2026-11-03 at 16:03 +0000, Tvrtko Ursulin wrote:
I'd like to get the fixes in so I can mentally focus on the continuation
of the bigger story. Not least that not fixing it causes sashiko to flag
the bugs, either when touching the neighbouring code, or possibly even
just the logical functionality.
Fine by me, no major objections :)
The only thing that makes me a bit uneasy is
drm_sched_entity_set_priority()'s semantic. I know it's only used by
amdgpu, but nevertheless the reader might be tempted to think it should
only change the priority of an entity within a runqueue.
Could you add some sort of code or doc comment hinting at there being a
TODO for the future rework? Good to have that in case any of us is
assigned to work on different projects in 2 months.
I lost you here - what should the comment say?
Regards,
Tvrtko
