Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] drm/gma500: missing Fixes: trailer for SGX MMU cache-flush fixes --
commit c92354a62278204d941ae70ac0f3b2869cb66190 Author: Gabriel Gama <[email protected]> > drm/gma500: Fix SGX page-table cache-flush mapping lifetime > > Flush the modified directory entry before unmapping it. The old order > uses a kmap_atomic pointer outside its mapping lifetime, which DMA32 > direct mappings can mask. Use kmap_local_page under the existing spinlock. > > Also calculate the CLFLUSH iteration count only on the path that uses it, > avoiding division by an uninitialized cache-line size when CLFLUSH > is absent. > > Signed-off-by: Gabriel Gama <[email protected]> [Severity: Low] Both the post-unmap cache flush in psb_mmu_pt_alloc_map_lock() and the unconditional division by clflush_add in psb_mmu_alloc_pt() were introduced in 8c8f1c958ab5 ("gma500: introduce the GTT and MMU handling logic"). Should this include a Fixes: tag? Fixes: 8c8f1c958ab5 ("gma500: introduce the GTT and MMU handling logic") -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=3
