Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/gma500: missing Fixes trailer for MMU error checks
--

commit 781534e30915fea9a7d73d13c97f11a95323ad77
Author: Gabriel Gama <[email protected]>

> drm/gma500: Propagate SGX MMU setup and GEM pin failures
>
> Check the GEM GPU address and perform transactional MMU insertion before
> changing cache attributes or publishing the GTT mapping. On failure,
> release temporary pages without publishing a pin and return the error.
>
> Propagate stolen-memory mapping failures through probe cleanup before
> installing a hardware context. Existing cache-attribute error handling
> is unchanged. This depends on the preceding rollback fix.
>
> Signed-off-by: Gabriel Gama <[email protected]>

[Severity: Low]
Since this fixes the unchecked psb_mmu_insert_pages() and
psb_mmu_insert_pfn_sequence() calls, should the commit message include a
Fixes tag?

  Fixes: ae012bdc5799 ("drm/gma500: Hook up the MMU")

-- 
Sashiko AI review ยท 
https://sashiko.dev/#/patchset/[email protected]?part=5

Reply via email to