Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Medium] drm/msm: link failure from unconditional DP MST calls when DRM_MSM_DP=n --
commit 45937631fc3531311a3391632556b054bf1c3512 Author: Yongxing Mou <[email protected]> drm/msm/dp: wire MST helpers into atomic check and commit paths This commit wires the DisplayPort MST atomic helper functions into the MSM KMS atomic check, commit setup, and commit tail paths. > diff --git a/drivers/gpu/drm/msm/msm_atomic.c > b/drivers/gpu/drm/msm/msm_atomic.c > index a8babf1dbe0d3..e70e5088cfe53 100644 > --- a/drivers/gpu/drm/msm/msm_atomic.c > +++ b/drivers/gpu/drm/msm/msm_atomic.c > @@ -4,6 +4,7 @@ > * Author: Rob Clark <[email protected]> > */ > > +#include <drm/display/drm_dp_mst_helper.h> > #include <drm/drm_atomic_uapi.h> > #include <drm/drm_vblank.h> > > @@ -207,7 +208,11 @@ int msm_atomic_check(struct drm_device *dev, struct > drm_atomic_commit *state) > if (ret) > return ret; > > - return drm_atomic_helper_check(dev, state); > + ret = drm_atomic_helper_check(dev, state); > + if (ret) > + return ret; > + > + return drm_dp_mst_atomic_check(state); > } > > void msm_atomic_commit_tail(struct drm_atomic_commit *state) > @@ -221,6 +226,8 @@ void msm_atomic_commit_tail(struct drm_atomic_commit > *state) > > trace_msm_atomic_commit_tail_start(async, crtc_mask); > > + drm_dp_mst_atomic_wait_for_dependencies(state); > + > kms->funcs->enable_commit(kms); > > /* > @@ -322,3 +329,8 @@ void msm_atomic_commit_tail(struct drm_atomic_commit > *state) > > trace_msm_atomic_commit_tail_finish(async, crtc_mask); > } > + > +int msm_atomic_commit_setup(struct drm_atomic_commit *state) > +{ > + return drm_dp_mst_atomic_setup_commit(state); > +} [Severity: Medium] Will calling drm_dp_mst_atomic_check(), drm_dp_mst_atomic_wait_for_dependencies(), and drm_dp_mst_atomic_setup_commit() unconditionally break the build when CONFIG_DRM_MSM_KMS is enabled and CONFIG_DRM_MSM_DP is disabled? msm_atomic.c is built under CONFIG_DRM_MSM_KMS, which only selects DRM_DISPLAY_HELPER, whereas drm_dp_mst_topology.o is built under CONFIG_DRM_DISPLAY_DP_HELPER (selected by CONFIG_DRM_MSM_DP) and drm_dp_mst_helper.h does not provide inline stubs when CONFIG_DRM_DISPLAY_DP_HELPER is disabled. Unless DRM_DISPLAY_DP_HELPER is selected by another enabled driver, linking fails with undefined references to these three symbols. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=22
