Thank you for your contribution! Sashiko AI review found 2 potential issues to consider: - [High] drm/msm/dpu: KMS init failure on SC8180X in _dpu_kms_initialize_displayport() - [Medium] drm/msm/dp: devres leak of msm_dp_panel in msm_dp_mst_attach_encoder() --
commit b76c85c1a18e10745adde0bb5001dc9b1e93e31a Author: Yongxing Mou <[email protected]> drm/msm/dpu: add per-stream MST encoders This commit creates a DRM encoder for each DP MST stream, associates it with a stream ID and panel, and sets up MST-specific encoder helper callbacks. > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > index 3c3203ca32c76..92691d39dcb24 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c > @@ -688,6 +688,21 @@ static int _dpu_kms_initialize_displayport(struct > drm_device *dev, > return rc; > } > } > + > + for (int stream_id = 0; stream_cnt > 1 && stream_id < > stream_cnt; stream_id++) { > + info.stream_id = stream_id; > + encoder = dpu_encoder_init(dev, DRM_MODE_ENCODER_DPMST, > &info); > + if (IS_ERR(encoder)) { > + DPU_ERROR("encoder init failed for dp mst > display\n"); > + return PTR_ERR(encoder); > + } [Severity: High] Does this break KMS initialization on SC8180X? In arch/arm64/boot/dts/qcom/sc8180x.dtsi, mdss_dp0 and mdss_dp1 both specify stream_pixel and stream_1_pixel in clock-names, so msm_dp_get_mst_max_stream() returns stream_cnt == 2. However, the SC8180X DPU catalog only has one INTF_DP entry per controller because the shared MST interface uses a dummy controller_id: drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_5_1_sc8180x.h:sc8180x_intf[] { ... /* INTF_3 is for MST, wired to INTF_DP 0 and 1, use dummy index until this is supported */ { .name = "intf_3", .id = INTF_3, .base = 0x6b800, .len = 0x280, .type = INTF_DP, .controller_id = 999, ... } When stream_id == 1, dpu_encoder_init() -> dpu_encoder_setup_display() -> dpu_encoder_get_intf() finds no second matching INTF_DP entry and returns NULL, causing _dpu_kms_initialize_displayport() to fail with -ENOMEM and aborting display initialization on SC8180X. > diff --git a/drivers/gpu/drm/msm/dp/dp_mst_drm.c > b/drivers/gpu/drm/msm/dp/dp_mst_drm.c > index a2900ff3b0ab3..ef5fb70863b81 100644 > --- a/drivers/gpu/drm/msm/dp/dp_mst_drm.c > +++ b/drivers/gpu/drm/msm/dp/dp_mst_drm.c > @@ -147,6 +147,26 @@ static int msm_dp_mst_encoder_stream_id(struct > msm_dp_mst *mst, > return -1; > } > > +int msm_dp_mst_attach_encoder(struct msm_dp *dp_display, unsigned int > stream_id, > + struct drm_encoder *encoder) > +{ > + struct msm_dp_mst *mst = dp_display->msm_dp_mst; > + struct msm_dp_panel *dp_panel; > + > + dp_panel = msm_dp_display_get_panel(dp_display, stream_id); > + if (!dp_panel) { > + drm_err(dp_display->drm_dev, > + "[MST] failed to allocate panel for stream %d\n", > stream_id); > + return -ENOMEM; > + } [Severity: Medium] Does calling msm_dp_display_get_panel() during KMS initialization leak struct msm_dp_panel_private across DRM component master bind/unbind cycles? msm_dp_display_get_panel() calls msm_dp_panel_get(), which allocates the panel with devm_kzalloc() on the subordinate DP platform device (&dp->msm_dp_display.pdev->dev). When the DRM master unbinds (or if a later step in msm_drm_init() fails), msm_dp_mst_unregister() frees struct msm_dp_mst, but the devres allocations on the persistent DP platform device remain and are reallocated on each subsequent bind. -- Sashiko AI review ยท https://sashiko.dev/#/patchset/[email protected]?part=16
