Thank you for your contribution! Sashiko AI review found no new issues
in this patch, but noticed 1 related pre-existing issue it does not
introduce:
- [High] drm/bridge: analogix_dp: unclocked MMIO access in
  analogix_dp_bridge_detect() [1]
--

commit fd813b0a1a5eac6ddf7400690200a86fc66c6e6d
Author: Marek Szyprowski <[email protected]>

drm/bridge: analogix_dp: Power down synchronously on bridge disable

This commit switches analogix_dp_set_bridge() and
analogix_dp_bridge_disable() from pm_runtime_put_sync() to
pm_runtime_put_sync_suspend() so the device runtime-suspends immediately
rather than waiting for the autosuspend timer.

> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c 
> b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index 8bb4c48aa3b48..022acb962b7ca 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -1021,7 +1021,7 @@ static int analogix_dp_set_bridge(struct 
> analogix_dp_device *dp)
>       return 0;
>  
>  out_dp_init:
> -     pm_runtime_put_sync(dp->dev);
> +     pm_runtime_put_sync_suspend(dp->dev);
>  
>       return ret;
>  }
> @@ -1163,7 +1163,7 @@ static void analogix_dp_bridge_disable(struct 
> drm_bridge *bridge)
>  
>       analogix_dp_set_analog_power_down(dp, POWER_ALL, 1);
>  
> -     pm_runtime_put_sync(dp->dev);
> +     pm_runtime_put_sync_suspend(dp->dev);
>  
>       dp->fast_train_enable = false;
>       dp->psr_supported = false;

[Severity: High]
This problem wasn't introduced by this patch, but can
analogix_dp_bridge_detect() access ANALOGIX_DP_SYS_CTL_3 while dp->dev is
runtime-suspended [1]?

drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:analogix_dp_bridge_detect() {
        if (dp->plat_data->next_bridge)
                return connector_status_connected;

        if (!analogix_dp_detect_hpd(dp))
                status = connector_status_connected;
}

When dp->plat_data->next_bridge is NULL, analogix_dp_bridge_detect() calls
analogix_dp_detect_hpd() without holding a runtime PM reference on
dp->dev.  If dp->hpd_gpiod is NULL (or dp->force_hpd is set),
analogix_dp_get_plug_in_status() and analogix_dp_force_hpd() read and
write ANALOGIX_DP_SYS_CTL_3 while the DP controller clocks and power
domain are off during connector polling with the display disabled, which
can trigger an external abort or bus hang on Exynos and Rockchip SoCs.

[1] https://sashiko.dev/#/bug/linux-ea09d64b-12cd-4301-bd54-12c515b01bde

-- 
Sashiko AI review ยท 
https://sashiko.dev/#/patchset/[email protected]?part=1

Reply via email to