On 19.11.2026 23:27, Marek Szyprowski wrote: > On 19.11.2026 19:31, Brian Norris wrote: >> On Thu, Nov 19, 2026 at 09:49:21AM +0100, Marek Szyprowski wrote: >>> The pipe (FIMD -> DP video) clock on Exynos is switched from the >>> analogix_dp runtime PM callbacks via plat_data->power_on()/power_off(), >>> which require the encoder to be still attached to a CRTC. The driver >>> relies on pm_runtime_put_sync() in analogix_dp_bridge_disable() to run >>> the runtime suspend callback immediately, while the encoder->crtc link >>> is still valid. >> This is a bit concerning, as this is somewhat of a misunderstanding of >> how runtime PM works. (But then, I guess it's not really surprising that >> people misunderstand runtime PM -- it's highly confusing.) >> >> Runtime PM cannot guarantee that something powers off, at least while >> runtime PM is enabled. It provides hints, but those can be overridden. >> >> A primary reason: /sys/.../<this_device>/power/control can be set to >> 'on', which means the device will always be prevented from >> runtime-suspending. So I assume that if you 'echo on > >> .../power/control', you'll still see the same bug. >> >> (It's possible that 'power/control' is the only way things break. I've >> wondered at times whether we should allow for drivers to opt out, and >> block this interface.) > > Sigh... Runtime PM API is highly confusing and imho a bit over-engineered. > > Indeed, after calling > > echo on > >/sys/bus/platform/drivers/exynos-dp/145b0000.dp-controller/power/control > > the display is broken again after suspend/resume cycle. It looks that the > source of this issue is in using runtime PM to control display pipe clocks. > After > moving that to encoder's enable/disable it works fine in all 3 cases: before > the > mentioned commit, after it and with power/control set to "on". This also > matches > the pipe clock handling in other Exynos DRM sub-drivers. Thanks for a > constructive review.
For the reference, this is the patch implementing this approach: https://lore.kernel.org/all/[email protected]/ Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland
