On 11/19/26 9:36 PM, [email protected] wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [Low] docs: ioctl-number: incomplete sequence range for
>   sound/scarlett2.h
> --
> 
> commit 93a4f635ed001735e939a3dc4a2526e8af9e9bd0
> Author: Randy Dunlap <[email protected]>
> 
> docs: ioctl-number: update sound entries
> 
> This commit updates the ioctl-number documentation table with additional
> sound subsystem files and sequence number ranges.
> 
>> diff --git a/Documentation/userspace-api/ioctl/ioctl-number.rst 
>> b/Documentation/userspace-api/ioctl/ioctl-number.rst
>> index e1d56d5cccd14..f29d2c17ca7b9 100644
>> --- a/Documentation/userspace-api/ioctl/ioctl-number.rst
>> +++ b/Documentation/userspace-api/ioctl/ioctl-number.rst
> 
> [ ... ]
> 
>> @@ -204,6 +209,9 @@ Code  Seq#    Include File                               
>>               Comments
>>  'S'   80-81  scsi/scsi_ioctl.h                                         
>> conflict!
>>  'S'   82-FF  scsi/scsi.h                                               
>> conflict!
>>  'S'   00-7F  sound/asequencer.h                                        
>> conflict!
>> +'S'   20-52  sound/core/seq/seq_compat.c                               
>> conflict!
>> +'S'   60-63  sound/scarlett2.h                                         
>> conflict!
> 
> [Severity: Low]
> Should the sequence range for sound/scarlett2.h be 60-64?
> include/uapi/sound/scarlett2.h also defines
> SCARLETT2_IOCTL_GET_ERASE_PROGRESS with sequence number 0x64:
> 
> include/uapi/sound/scarlett2.h:
> #define SCARLETT2_IOCTL_GET_ERASE_PROGRESS \
>       _IOR('S', 0x64, struct scarlett2_flash_segment_erase_progress)

Yes. Fixed now.

-- 
~Randy

Reply via email to