Michael Fitzpatrick wrote:
> 
> CVSROOT:        /cvsroot/dri
> Module name:    xc
> Repository:     xc/xc/lib/GL/mesa/src/drv/radeon/
> Changes by:     leahcim@usw-pr-cvs1.    02/03/09 20:16:11
> 
> Log message:
>   Fix IDX typo. Fix tcl_vertex_format breakage (better fix for
>   this? Fixes a heap of demos / samples and Tuxracer)

The rmesa->vertex_format / rmesa->tcl_vertex_format thing is all kindof broken
and has been the source of quite a few bugs.  The real problem is that there
are 3 files all which believe that rmesa->vertex_format is their own private
state that they can modify at will without notifying anyone else.  When they
get swapped between (_tris.c, _tcl.c, _vtxfmt.c) they often find the rest of
their state out of sync with rmesa->vertex_format.

An obvious thing to do would be to triplicate that variable and give them each
a private copy & make sure nobody else uses it (ie pass it as a parameter to
all external usage of the field)

Keith

_______________________________________________
Dri-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/dri-devel

Reply via email to