Michel Dänzer wrote:
On Mon, 2002-11-25 at 23:21, Brian Paul wrote:

There are two places in radeon_ioctl.c where the INREG() macro is used to
read register values (RADEON_LAST_FRAME_REG and RADEON_LAST_CLEAR_REG).

It looks like these have been superceeded by drmCommandWriteRead() calls
(since the 11 July check-in of Tim Smith's changes).  INREG is probably
only used if the kernel module is too old to support the RADEON_LAST_-
CLEAR/FRAME queries.

It would be nice if those two instances of INREG() could be removed.

I suppose we need to keep them for the sake of users of older radeon.o
kernel modules.  Is there more to it than that?

I don't see any other reason, the registers are only read directly if
there's a problem with the ioctl. I know Eric used to frown at the idea
of using an ioctl to get a register value though. :)
It's not even that: We're using an ioctl to read a value *in main memory*... If we were smart it would be in a shared page accessible from userspace...

Keith



-------------------------------------------------------
This SF.net email is sponsored by: Get the new Palm Tungsten T
handheld. Power & Color in a compact size!
http://ads.sourceforge.net/cgi-bin/redirect.pl?palm0002en
_______________________________________________
Dri-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/dri-devel

Reply via email to