Roland Scheidegger wrote:
@@ -888,9 +1070,9 @@ _mesa_lookup_enum_by_nr( pname ) ); }
- if ( ( target != GL_TEXTURE_2D ) && +/* if ( ( target != GL_TEXTURE_2D ) && ( target != GL_TEXTURE_1D ) ) - return; + return;*/
Wouldn't this change be enough on its own? This test is broken & has probably been causing subtle problems for ages.
Wow. That *is* broken. The R100 driver has a similar problem. Instead of removing it, shouldn't the test be updated? Perhaps a change similar to the one I made in r200BindTexture would be in line? Hmm...maybe a new function like r200_valid_hw_texture_target that did the test would be the right way to go. That way the code only has to be updated in one place if support for a new texture target is added.
In any case, just updating that test to include GL_TEXTURE_RECTANGLE_NV (and the other valid targets too) fixes the problem with texrect for me on r200.
------------------------------------------------------- The SF.Net email is sponsored by EclipseCon 2004 Premiere Conference on Open Tools Development and Integration See the breadth of Eclipse activity. February 3-5 in Anaheim, CA. http://www.eclipsecon.org/osdn -- _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
