Keith Whitwell wrote:
Roland Scheidegger wrote:
@@ -888,9 +1070,9 @@ _mesa_lookup_enum_by_nr( pname ) ); }
- if ( ( target != GL_TEXTURE_2D ) && +/* if ( ( target != GL_TEXTURE_2D ) && ( target != GL_TEXTURE_1D ) ) - return; + return;*/
Wouldn't this change be enough on its own? This test is broken & has probably been causing subtle problems for ages.
Wow. That *is* broken. The R100 driver has a similar problem. Instead of removing it, shouldn't the test be updated? Perhaps a change similar to the one I made in r200BindTexture would be in line?
I don't see any reason not to keep all texture objects uptodate. It's not going to alter performance in the case where the app is doing lots of work on non-supported texture dimensions, as there'll be fallbacks all over the place anyway. Why not just go for the obviously-correct solution & ditch the test?
Keith
------------------------------------------------------- The SF.Net email is sponsored by EclipseCon 2004 Premiere Conference on Open Tools Development and Integration See the breadth of Eclipse activity. February 3-5 in Anaheim, CA. http://www.eclipsecon.org/osdn -- _______________________________________________ Dri-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/dri-devel
