On Fri, 2005-03-11 at 23:02 +1100, Paul Mackerras wrote: > Michel DÃnzer writes: > > > The difference is that for a hostdata blit, the CP writes the data to > > the hostdata registers synchronously, whereas with your change, the 2D > > engine will fetch the data asynchronously. > > What do you think of this patch? I have added a wait command after > the blit, which I believe should make the CP wait until the blit is > done before writing the buffer age scratch register.
Yes, that looks good. > I also made it set the source pitch based on the image width. If the > image width is less than 64, we have a problem if the image height is > more than 1 (if the height is 1 the pitch doesn't matter). I made it > return an EINVAL error in that case. I didn't see that case ever > occurring, at least with the r300 driver. Looks good to me as well, if this error gets triggered by the other drivers, we can always deal with that. I'll defer to Roland for whether this is fine for texture tiling though. -- Earthling Michel DÃnzer | Debian (powerpc), X and DRI developer Libre software enthusiast | http://svcs.affero.net/rm.php?r=daenzer ------------------------------------------------------- SF email is sponsored by - The IT Product Guide Read honest & candid reviews on hundreds of IT Products from real users. Discover which products truly live up to the hype. Start reading now. http://ads.osdn.com/?ad_ide95&alloc_id396&op=click -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
