-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Roland Scheidegger wrote:
> Ian Romanick wrote:
>
>>>> At my point of view
>>>> defines IN_DRI_DRIVER and USE_EXTERNAL_DXTN_LIB=1 are very specific and
>>>> only used in Mesa.
>>>> So the patch on bug #5057 ( the last one ) or something similar, don't
>>>> see what problems can cause on applying it.
>>>
>>> The problem in applying it is that we are in RCfinal now. This was a
>>> known issue for over a month and was never put on the release
>>> blocker, so apparently wasn't critical enough to block the release.
>>>
>>> Yes, this sucks. But we have process rules for a reason.
>>
>> WHOA!!! Without IN_DRI_DRIVER, building DRI drivers is 100% broken. If
>> we ship like this, we're shipping something that is completely KNOWN to
>> be broken and will NEVER have ANY chance of working. I thought this was
>> applied over a month ago. What happened?
>
> Well, nothing... I forgot to add it to the blocker bug, and apparently
> noone else did neither. Do you know off-hand what exactly will break if
> it isn't defined? It seems to work just fine on first look (save that
> exception), though there are definitely some files touched by it.
There are several files, including mesa/glapi/{glapioffsets,dispatch}.h
and mesa/main/{context,api_arrayelt}.c that depend on IN_DRI_DRIVER
being set properly. If it's not set, the drivers *will* be built
incorrectly. These are all pretty important.
I suspect that we haven't had bug reports because people testing 3D
drivers are building them (properly!!!) directly from the Mesa tree.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
iD8DBQFDpI9DX1gOwKyEAw8RAm74AJ98Ok75HDGpcD8NoGQNWCVhBKtoQwCgm6ez
yc8bxjUcVqhT7wKUx4r9ooM=
=xQb9
-----END PGP SIGNATURE-----
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel
