On Monday, June 11, 2007 7:32:34 Jesse Barnes wrote: > On Monday, June 11, 2007 7:13:04 Jesse Barnes wrote: > > On Monday, June 11, 2007 6:42:09 Keith Packard wrote: > > > On Mon, 2007-06-11 at 15:20 -0700, Jesse Barnes wrote: > > > > +static u32 last_vblank; /* protected by dev->vbl_lock */ > > > > > > uh. per crtc? > > > > Oh, hm yeah. I guess it'll have to go in drm_device. > > Actually with the lock there I think it's safe. But if I move it to > drm_device I can get rid of the locking, so I guess I'll do that (that way > we can call drm_vblank_get under the vbl_lock).
Ok ignore me. I've been looking at this too long. Need per-crtc last counts *and* the lock, otherwise multiple clients could hose one another's wraparound logic (though it's fairly unlikely given the reference counting). Jesse ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
