On Tue, 2007-08-28 at 21:50 +0100, Dave Airlie wrote: > On Tue, 28 Aug 2007, Christoph Hellwig wrote: > > > On Mon, Aug 27, 2007 at 10:57:50PM +0200, [EMAIL PROTECTED] wrote: > >> Hello, > >> > >> As there are many places in drm code where drm_alloc + memset is used > >> this patch series introduces drm_zalloc and also makes use of drm_calloc > >> where > >> needed. Most of these patches save some bytes so the benefit is a few kB > >> saved > >> (gcc 4.1.2) with patch applied. Also some small (style, etc.) things are > >> fixed. > >> This patch series does the conversion drm tree-wide. All patches were > >> compile > >> tested. > > > > Please just convert it to plain kzalloc/kcalloc and kill these utterly > > useless > > wrappers instead. > > > > > > The wrappers aren't useless the drm alloc/free passes in a memory space > for debugging purposes so we can track memory abuse when developing,
Do we ever use that, though? Having to pass in the pointer, the size and the area just to free memory, sure is a bitch. > but drm_zalloc shouldjust alias to drm_calloc really.. drm_calloc calls kcalloc which performs an integer overflow check on the 'n' and 'size' arguments, which isn't needed for drm_zalloc. Small detail, of course, but I don't see the problem with aliasing to kzalloc. Kristian ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
