On Wed, 2007-09-26 at 15:43 +0100, Keith Whitwell wrote:
> Alan Hourihane wrote:
> > linux-core/drm_drv.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > New commits:
> > diff-tree 6671ad1917698b6174a1af314b63b3800d75248c (from
> > 03c47f1420bf17a1e0f2b86be500656ae5a4c95b)
> > Author: Alan Hourihane <[EMAIL PROTECTED]>
> > Date: Wed Sep 26 15:38:54 2007 +0100
> >
> > don't copy back if an error was returned.
> >
> > diff --git a/linux-core/drm_drv.c b/linux-core/drm_drv.c
> > index cedb6d5..8513a28 100644
> > --- a/linux-core/drm_drv.c
> > +++ b/linux-core/drm_drv.c
> > @@ -645,7 +645,7 @@ long drm_unlocked_ioctl(struct file *fil
> > retcode = func(dev, kdata, file_priv);
> > }
> >
> > - if (cmd & IOC_OUT) {
> > + if ((retcode == 0) && cmd & IOC_OUT) {
>
> Hmm, brackets around the == but not around the & ??
>
> Could you humour me and change that to something like:
>
> if (retcode == 0 && (cmd & IOC_OUT)) {
Sure. should of caught that.
Alan.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
--
_______________________________________________
Dri-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dri-devel
