On Sat, 2008-04-26 at 17:14 -0700, Jesse Barnes wrote:
>
> New commits:
> commit b45fe49bcd989be4e1327c13dd734410b395761c
> Author: Jesse Barnes <[EMAIL PROTECTED](none)>
> Date: Sat Apr 26 17:11:18 2008 -0700
>
> Enum-ectomy of vblank modesetting ioctl
>
> Enum can be of pretty much any size since C leaves the choice of size up
> to the implementation. So avoid using it in new interfaces like the vblank
> pre- & post-modeset ioctl. Thanks to hch for spotting this.
[...]
> @@ -567,7 +566,7 @@ enum drm_modeset_ctl_cmd {
> */
> struct drm_modeset_ctl {
> unsigned long arg;
> - enum drm_modeset_ctl_cmd cmd;
> + int cmd;
> };
Meanwhile, unsigned long definitely requires special handling with 32
bit userspace on a 64 bit kernel... it should probably be replaced with
a fixed size type, but I'm not sure if it needs 64 bits or if 32 are
sufficient.
--
Earthling Michel Dänzer | http://tungstengraphics.com
Libre software enthusiast | Debian, X and DRI developer
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Don't miss this year's exciting event. There's still time to save $100.
Use priority code J8TL2D2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
--
_______________________________________________
Dri-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dri-devel
