2009/6/11 Kristian Høgsberg <k...@redhat.com>: > On Wed, 2009-06-10 at 15:20 +1000, Dave Airlie wrote: >> Hi Kristian et al >> >> So you wrote YALL for glxAllContexts and like all good linked list >> re-implementations it didn't work :-) > > Well that's how we do data structures in the X server, open coded and > badly. > >> So the attached patch fixes the linked list remove function, so we do >> clean up the drawable and context properly. >> >> However now I'm getting a glean failure on the makeCurrent test
So glXMakeCurrent says GLXBadCurrentWindow is generated if there are pending GL commands for the previous context and the current drawable is a window that is no longer valid. This appears to be true, we don't seem to have cleared all the pending GL commands before, so we get this error. Adding a glFinish into the glean test exit path, gets it past this, but I've no idea if this is correct. I then hit a GLXBadContext soon afterwards which suggest something more is going wrong. Probably need someone with some knowledge of GLX to tell me more. Brian? Ian? Dave. >> >> [airl...@pegasus piglit]$ ./bin/glean -o -r dave -t makeCurrent >> makeCurrent: PASS rgba8, db, z24, s8, win+pmap, id 33 >> X Error of failed request: GLXBadCurrentWindow >> Major opcode of failed request: 152 (GLX) >> Minor opcode of failed request: 5 (X_GLXMakeCurrent) >> Serial number of failed request: 103 >> Current serial number in output stream: 103 >> >> this is better than what I was getting before I fixed it which was my >> X server crashing. >> >> However I'm just wondering if anyone knows what the proper behaviour >> is here, glean test needs fixing? >> or our GLX implementation needs fixing? > > The patch is definitely a step in the right direction, but I suspect > glean is right though and that something else is wrong in the glx code. > I'll try to take a look. > > cheers, > Kristian > > > ------------------------------------------------------------------------------ Crystal Reports - New Free Runtime and 30 Day Trial Check out the new simplified licensing option that enables unlimited royalty-free distribution of the report engine for externally facing server and web deployment. http://p.sf.net/sfu/businessobjects -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel