>>> Jeremy Fitzhardinge <jer...@goop.org> 30.09.09 20:43 >>> >On 09/30/09 03:13, Jan Beulich wrote: >> This is for avoiding translation of the passed in address in virtual >> environments like Xen. >> > >Ah, thanks. I suspected one of these was missing and was about to go >hunting for it. Do think other DRI drivers are missing this too?
No, not as far as I can tell. >Hm, _PAGE_IOMAP is x86-specific. I guess that doesn't matter in this >case, but it would for other drivers. Previously _PAGE_IOMAP was set in >vm_get_page_prot -> arch_vm_get_page_prot. Is that path no longer being >used? It looks like it should be. No, that path can't be the right one: Based on what VM_* flag would you want to set _PAGE_IOMAP? VM_IO is definitely not the right one - I checked this with Nick when analyzing the crash we got reported. Further, no arch besides powerpc actually defines arch_vm_get_page_prot() in mainline, and in xen/master the definition indeed is (incorrectly) using VM_IO. Jan ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf -- _______________________________________________ Dri-devel mailing list Dri-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dri-devel
